Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/docs: Add Passkeys reference where WebAuthn is mentioned #13167

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

melizeche
Copy link
Contributor

@melizeche melizeche commented Feb 21, 2025

Details

Add Passkeys reference in several parts where WebAuthn is mentioned for better docs UX and SEO)

Rationale:

Passkeys is the de-facto term when people think about passwordless login and biometric 2fa and there's nothing on the website or docs that mention that term

image

image


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@melizeche melizeche requested a review from a team as a code owner February 21, 2025 19:24
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 74ecb22
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/67b8df4f3747ab000849225e
😎 Deploy Preview https://deploy-preview-13167--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 74ecb22
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/67b8df4f3747ab000849225c

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (c7567e0) to head (74ecb22).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13167      +/-   ##
==========================================
- Coverage   92.71%   92.70%   -0.01%     
==========================================
  Files         792      792              
  Lines       40231    40231              
==========================================
- Hits        37302    37298       -4     
- Misses       2929     2933       +4     
Flag Coverage Δ
e2e 48.11% <ø> (-0.06%) ⬇️
integration 24.13% <ø> (ø)
unit 90.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@melizeche melizeche requested a review from tanberry February 21, 2025 19:30
@melizeche melizeche changed the title Add Passkeys reference where WebAuthn is mentioned website/docs: Add Passkeys reference where WebAuthn is mentioned Feb 21, 2025
Copy link
Contributor

github-actions bot commented Feb 21, 2025

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-74ecb2243e2aa34c35abced90741c0e5f8b1d6e3
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-74ecb2243e2aa34c35abced90741c0e5f8b1d6e3

Afterwards, run the upgrade commands from the latest release notes.

@dominic-r
Copy link
Contributor

dominic-r commented Feb 21, 2025

Technically, WebAuthn != Passkey. If i'm not mistaken, WebAuthn is the web standard for passwordless authentication and passkeys are a type of credential which implement that standard. If we want to ignore technicalities, LGTM. - Is it worth breaking the docs' technical accuracy for UX?

Here's a source which confirms it: https://www.corbado.com/faq/how-does-webauthn-differ-from-passkeys

@melizeche
Copy link
Contributor Author

@dominic-r Yup, I agree they are not the same thing, but is the term that most users are familiar with (at least more than WebAuthn). As I said, this is more about UX and SEO because if a user doesn't know that WebAuthn is the protocol, they might think that authentik doesn't support passkeys

but because this is a docs issue I'd like to get @tanberry approval before merging

@dominic-r
Copy link
Contributor

Just throwing this out there, Teffen added tags to the Google docs: https://github.com/goauthentik/authentik/blob/main/website/docs/users-sources/sources/social-logins/google/workspace/index.md?plain=1#L4 . Does that show up in search? If so, that could be a decent idea as well? I agree about SEO and UX and yea let's get tana's opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants