(BEDS-1319) split validator addition #1382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remoterami
force-pushed
the
BEDS-1319/split-validator-addition
branch
from
16f644a to
20f3997
Compare
remoterami
force-pushed
the
BEDS-1319/split-validator-addition
branch
from
20f3997 to
39ceca5
Compare
remoterami
force-pushed
the
BEDS-1319/split-validator-addition
branch
from
39ceca5 to
c38d76e
Compare
|
|
LuccaBitfly
requested changes
Mar 6, 2025
Comment on lines
36
to
47
| query, args, err := validatorsDs.Prepared(true).ToSQL() | ||
| if err != nil { | ||
| return nil, fmt.Errorf("error preparing query: %w", err) | ||
| } | ||
|
|
||
| var validators []uint64 | ||
| err = d.alloyReader.SelectContext(ctx, &validators, query, args...) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| ebsBeforeExit := []struct { | ||
| ValidatorIndex uint64 `db:"validator_index"` | ||
| EffectiveBalance uint64 `db:"balance_effective_end"` | ||
| }{} | ||
| err = d.clickhouseReader.SelectContext(ctx, &ebsBeforeExit, query, args...) | ||
| if err != nil && err != sql.ErrNoRows { | ||
| return validators, nil |
There was a problem hiding this comment.
Nitpick: could simply do:
return runQueryRows[[]uint64](ctx, d.alloyReader, validatorsDs)(same for all other queries)
backend/pkg/api/handlers/public.go
Outdated
| } | ||
| existingValidatorsMap := utils.SliceToMap(existingValidators) | ||
| ebSpaceLeft := ebLimit - totalExistingEb |
There was a problem hiding this comment.
Issue: this could overflow if the archiver is slow, should check if totalExistingEb is smaller than ebLimit before.
var ebSpaceLeft uint64
if (ebLimit > totalExistingEb){
ebSpaceLeft = ebLimit - totalExistingEb
}| func (d *DataAccessService) GetValidatorDashboardEffectiveBalanceTotal(ctx context.Context, dashboardId t.VDBId, onlyActive bool) (uint64, error) { | ||
| // returns the effective balances of the provided validators | ||
| // if onlyActive = true: executed from the vdb premium limits pov, i.e. exited validators account for the EB at exit time | ||
| func (d *DataAccessService) GetValidatorDashboardEffectiveBalances(ctx context.Context, dashboardId t.VDBId, onlyActive bool) (map[t.VDBValidator]uint64, error) { |
There was a problem hiding this comment.
Issue: This should not be a dashboard func where you pass the dashboard ID but simply GetValidatorEffectiveBalances where you pass a list of validators, since in
GetValidatorEffectiveBalances here
LuccaBitfly
reviewed
Mar 6, 2025
There was a problem hiding this comment.
Otherwise very nice way of unifying all types of adding validators. IMO it's much clearer what's happening now. 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tackles #1367 (comment) / #1367 (comment)