Non blocking blockwise get #782
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call the user-provided write block callback from the `on_block_rcvd()` callback running on the coap client thread, rather than from the loop in `golioth_blockwise_get()` running on the user thread. This removes a memcpy, and makes block downloads non-blocking. But it does mean that time user supplied write block callbacks now execute on the coap client thread and care must be taken to ensure the client thread is not unduly blocked. Signed-off-by: Sam Friedman <sam@golioth.io>
Signed-off-by: Sam Friedman <sam@golioth.io>
sam-golioth
force-pushed
the
non_blocking_blockwise_get
branch
from
71ba68b to
3634d7e
Compare
|
Visit the preview URL for this PR (updated for commit 3634d7e): https://golioth-firmware-sdk-doxygen-dev--pr782-non-blocking-b-y80rqopl.web.app (expires Thu, 08 May 2025 19:05:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
Code Coverage
|
Codecov ReportAttention: Patch coverage is
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the golioth_coap_blockwise_get to be non-blocking, with block write callbacks executed on the coap client thread. Users are responsible for ensuring that they do not block the client thread unduly.
A second commit in this PR also reworks and simplifies the way that block retries are executed in the fw_update module. This simplifies program flow, removes a
while(1)loop, and reduces the amount of state that has to be moved between the callback and the thread. One of the consequences is that we no longer report to the OTA state service when we retry a block download. I think that's acceptable and even desirable because: