Skip to content

Wno-error=sign-compare 4 fuzztest on GLIBC>2.34-8 #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Wno-error=sign-compare 4 fuzztest on GLIBC>2.34-8 #765

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67a92fa
Wno-error=sign-compare 4 fuzztest on GLIBC>2.34-8
Oct 24, 2022
20adb2c
Add no-error attributes to avoid needing google-fuzztest to accept my
Oct 24, 2022
79861dc
PR fix
Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ build --cxxopt='-Werror' --cxxopt='-Wall'
build --features=external_include_paths
build --cxxopt='-Wno-deprecated-declarations'

# These are needed on systems with GLIBC > 2.34-8 to build google-fuzztest
# which has these errors.
build --cxxopt='-Wno-error=sign-compare'
build --cxxopt='-Wno-error=attributes'

# Why are we doing this when Souffle-generated C++ clearly uses exceptions?
# Well, Google famously does not like C++ exceptions in its internal codebase,
# so we will need to explicitly override that in Raksha files everywhere we
Expand Down