Skip to content

LineCursor can loop forward, but not back #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
microbit-robert opened this issue Apr 15, 2025 · 0 comments
Open

LineCursor can loop forward, but not back #440

microbit-robert opened this issue Apr 15, 2025 · 0 comments

Comments

@microbit-robert
Copy link
Contributor

This is in normally navigation mode only. Move mode works as expected.

We've patched this temporarily. Note, this patch also contains changes to remove the stack connection cursor positions. Disregard changes to validLineNode and validInLineNode. Patch diff.

Summary of relevant changes:

  • Change the prev and out methods to call getPreviousNode with the loop param set to true.
  • I also pass the isValid function to getLastNode, which is passed through getNextNode where it's called inside getLastNode (required to avoid errors on looping back).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant