Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uk: Regenerate translation for Comprehensive Rust v2 #1598

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

reta
Copy link
Contributor

@reta reta commented Dec 19, 2023

uk: Regenerate translation for Comprehensive Rust v2

Signed-off-by: Andriy Redko <drreta@gmail.com>
@reta
Copy link
Contributor Author

reta commented Dec 19, 2023

@mgeisler @dyeroshenko would appreciate your guidance here (follow up on #1494 (comment)), what I did:

$ MDBOOK_OUTPUT='{"xgettext": {"pot-file": "messages.pot"}}'   mdbook build -d po
msgmerge --update po/uk.po po/messages.pot

@dyeroshenko
Copy link
Collaborator

@mgeisler @dyeroshenko would appreciate your guidance here (follow up on #1494 (comment)), what I did:

$ MDBOOK_OUTPUT='{"xgettext": {"pot-file": "messages.pot"}}'   mdbook build -d po
msgmerge --update po/uk.po po/messages.pot

Considering the size and machine generated nature of the translation I would merge it and work on fixing the wording in the following commits?

@reta
Copy link
Contributor Author

reta commented Dec 19, 2023

Considering the size and machine generated nature of the translation I would merge it and work on fixing the wording in the following commits?

Thanks @dyeroshenko , that's the plan indeed :)

@dyeroshenko dyeroshenko merged commit 7514507 into google:main Dec 19, 2023
32 checks passed
@mgeisler
Copy link
Collaborator

mgeisler commented Jan 5, 2024

@mgeisler @dyeroshenko would appreciate your guidance here (follow up on #1494 (comment)), what I did:

$ MDBOOK_OUTPUT='{"xgettext": {"pot-file": "messages.pot"}}'   mdbook build -d po
msgmerge --update po/uk.po po/messages.pot

That looks correct! We merged in a lot of changes in #1073, so this explains most of the large diff.

I use

gh pr diff 1598 | bat -l patch

myself to skim these PRs.

@reta
Copy link
Contributor Author

reta commented Jan 5, 2024

myself to skim these PRs.

Thanks a lot @mgeisler , the translation is progressing! Nonetheless it adds some work, the v2 looks better structured (my opinion), thank you folks!

@mgeisler
Copy link
Collaborator

mgeisler commented Jan 5, 2024

I'm sorry about the extra work, but I also agree that it's better structured now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants