Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mdbook-pandoc and disable it except during CI workflows #2212

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

max-heller
Copy link
Collaborator

Implements the approach summarized in google/mdbook-i18n-helpers#200 (comment) to disable running mdbook-pandoc even if it is available to avoid dependency-related issues during local rendering.

Should address #1911 since mdbook-pandoc will no longer run locally.

Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciated!

@mgeisler mgeisler merged commit df2076b into google:main Jul 18, 2024
34 checks passed
@mgeisler
Copy link
Collaborator

Thanks a lot, @max-heller!

@max-heller max-heller deleted the upgrade-mdbook-pandoc branch July 18, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants