Split C interop slides into smaller slides. #2645
Merged
+72
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of google#2445. This splits up the slides in the interop with C section into smaller slides. For calling C from Rust, instead of the long slide containing the sample C lib, explaining bindgen, and how to run the Rust code, these are now presented on separate slides. Similarly for calling Rust from C, the simple Rust library is on its own slide, followed by a slide on how to then call and run the Rust library from C.
randomPoison
requested changes
Feb 14, 2025
Comment on lines
25
to
32
| Create a wrapper header file for the library (not strictly needed in this | ||
| example): | ||
|
|
||
| _interoperability/bindgen/libbirthday_wrapper.h_: | ||
|
|
||
| ```c | ||
| {{#include bindgen/libbirthday_wrapper.h:include}} | ||
| ``` |
There was a problem hiding this comment.
This should be moved to the next slide about using bindgen. This is part of the bindgen setup, not the setup for the C library.
There was a problem hiding this comment.
Thanks for reviewing! I've made the adjustment.
randomPoison
approved these changes
Feb 17, 2025
|
Everything looks good now, thanks for the contribution! ❤️ |
auto-merge was automatically disabled
February 21, 2025 11:05
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
February 22, 2025 07:09
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2445.
This splits up the slides in the interoperability with C section into smaller slides.
For calling C from Rust, instead of the long slide containing the sample C lib, explaining bindgen, and how to run the Rust code, these are now presented on separate slides.
Similarly for calling Rust from C, the simple Rust library is on its own slide, followed by a slide on how to then call and run the Rust library from C.