Report skipped test in the runner mode instead of the controller mode. #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
With this change, FuzzTest no longer needs to instantiate the fixture in the controller mode, and setup failures in the fixture instantiation can be captured (otherwise they would crash the controller process). Because of this, a few fixture test expectation become trickier. Note that there can be setup failures that cannot be captured, such as environment setup and the static SetUpTestSuite function. But this is still a step forward. PiperOrigin-RevId: 745598295
copybara-service
bot
force-pushed
the
cl/745598295
branch
from
7fc7da3 to
1af56b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report skipped test in the runner mode instead of the controller mode.
With this change, FuzzTest no longer needs to instantiate the fixture in the controller mode,
and setup failures in the fixture instantiation can be captured (otherwise they would crash the controller process).
Because of this, a few fixture test expectation become trickier.
Note that there can be setup failures that cannot be captured, such as environment setup and the static SetUpTestSuite function. But this is still a step forward.