Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of small client #62

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Implementation of small client #62

merged 1 commit into from
Mar 16, 2024

Conversation

Hu6li
Copy link
Contributor

@Hu6li Hu6li commented Feb 26, 2024

This pull request addresses issue #27

Implementing a simple client for cloudspanner/postgres
Currently it is only possible to query and print samples formatted as json
This can of course be extended into a more powerful client.

Please let me know what you think

Copy link

google-cla bot commented Feb 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Hu6li Hu6li force-pushed the client branch 3 times, most recently from 6a4db59 to 0f7b2bf Compare February 26, 2024 23:28
@meeehow
Copy link
Collaborator

meeehow commented Mar 8, 2024

Hi @Hu6li, thank you for this pull request! Would it be possible to decouple the server code from the client code? What I mean is to keep all the code that the client uses in the "main" package, under /client

@Hu6li
Copy link
Contributor Author

Hu6li commented Mar 8, 2024

Hi @meeehow sure this is possible.
Is your intention to run the client as a complete independent program?
This would probably mean having some code redundancy overall as we wouldn't reuse parts of the already existing interfaces and create new/separate ones.

@meeehow
Copy link
Collaborator

meeehow commented Mar 8, 2024

@Hu6li Yes, the idea would be to have the server and the client code independent of each other. IIUC for this PR there shouldn't be much too of code redundancy, you'd just need to create the cloudspanner and postgres clients (and potentially structs).

Copy link
Collaborator

@meeehow meeehow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you just fix the issue below?

"don't use underscores in Go names; var file_output should be fileOutput"

@meeehow meeehow merged commit b576869 into google:main Mar 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants