Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate repeated sources #154

Closed
mgeisler opened this issue Jan 24, 2024 · 3 comments · Fixed by #156
Closed

Deduplicate repeated sources #154

mgeisler opened this issue Jan 24, 2024 · 3 comments · Fixed by #156
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mgeisler
Copy link
Collaborator

With #145 merged, we can now end up in a situation where a message has the same source repeated multiple times:

#: src/SUMMARY.md:10 src/SUMMARY.md:10 src/SUMMARY.md:70 src/SUMMARY.md:90
msgid "Welcome"
msgstr "Te damos la bienvenida"

We should add logic to remove the duplicates in this case. The situation becomes even worse when the line numbers are removed completely (when granularity is set to 0).

@zachcmadsen
Copy link
Contributor

Hey @mgeisler, I'm interested in taking this. Based on #145, it looks like we'd need to handle duplicates whenever we call add_message in create_catalog. Am I on the right track?

@mgeisler
Copy link
Collaborator Author

mgeisler commented Feb 6, 2024

Hi @zachcmadsen, thanks for taking this on! I think you're definitely on the right track!

@mgeisler
Copy link
Collaborator Author

mgeisler commented Feb 6, 2024

I just created #171, which is related to this (but can be fixed independently).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants