Add proper JSON escaping in crash report templates #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DonggeLiu does this seem fine? |
|
Thanks @Kartikayy007. Meanwhile, would @Ekam219's suggestions sound good to you? |
|
Experiment launched in #918 For follow-up changes, let's create new PRs based on google:exp-905 : ) |
yes sounds good and can be implemented, Its already implemented in #906 |
|
Thanks @Kartikayy007! That sounds great. I've already created the PR with the update. Let me know if you have any feedback!" |
DonggeLiu
pushed a commit
that referenced
this pull request
Mar 24, 2025
# Fix JSON format errors in crash reports ## Description This PR fixes JSON format errors in crash reports due to improper escaping or were missing quotes entirely, causing parsing errors referenced in issue. fixes: #903 ## Changes * Added proper quotes around template expressions * Added proper escaping for double quotes with `\"` * Added proper formatting for newlines as `\n` ## Example Before: ```json { "samples": [ { "coverage_report": "#", "stacktrace": "/stacktrace", "target_binary": "/target_binary", "reproducer": "/artifacts", "run_log": "run.log", "source_code": , "model": "claude-3-opus-20240229" } ] } ``` After: ```json { "samples": [ { "coverage_report": "#", "stacktrace": "SIGSEGV\ncrash at 0x004a3f21\n#0 0x004a3f21 in function()", "target_binary": "/target_binary", "reproducer": "/artifacts", "run_log": "run.log", "source_code": "#include <stdint.h>\n#include <stdlib.h>\nint LLVMFuzzerTestOneInput() {...}", "model": "claude-3-opus-20240229" } ] } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JSON format errors in crash reports
Description
This PR fixes JSON format errors in crash reports due to improper escaping or were missing quotes entirely, causing parsing errors referenced in issue.
fixes: #903
Changes
\"\nExample
Before:
{ "samples": [ { "coverage_report": "#", "stacktrace": "/stacktrace", "target_binary": "/target_binary", "reproducer": "/artifacts", "run_log": "run.log", "source_code": , "model": "claude-3-opus-20240229" } ] }After:
{ "samples": [ { "coverage_report": "#", "stacktrace": "SIGSEGV\ncrash at 0x004a3f21\n#0 0x004a3f21 in function()", "target_binary": "/target_binary", "reproducer": "/artifacts", "run_log": "run.log", "source_code": "#include <stdint.h>\n#include <stdlib.h>\nint LLVMFuzzerTestOneInput() {...}", "model": "claude-3-opus-20240229" } ] }