Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to the new flame graph implementation by default and remove d3 dependency #777

Closed
aalexand opened this issue May 2, 2023 · 3 comments · Fixed by #825
Closed

Switch to the new flame graph implementation by default and remove d3 dependency #777

aalexand opened this issue May 2, 2023 · 3 comments · Fixed by #825
Labels
Priority: p2 Buganizer priority - P2 type: cleanup Buganizer type - Internal Cleanup

Comments

@aalexand
Copy link
Collaborator

aalexand commented May 2, 2023

d3 dependency has been heavy toil to carry in pprof - version upgrades like #748 can be difficult when there is a version mismatch between the OSS version and the internal version used at Google. We also don't feel that the d3 usage provides enough value.

The current plan is to switch to the new flame graph implementation in the web UI, then after some time turn down the current d3-based flame graph implementation and the d3 dependency overall.
@aalexand aalexand mentioned this issue May 2, 2023
Closed
ghemawat added a commit to ghemawat/pprof that referenced this issue May 8, 2023
@ghemawat
Made non-D3 flamegraph view the default.
c851805 
In preparation for removing the dependency on D3 make the
new flamegraph view the default. The old view is still available
under /flamegraphold for now.

See issue google#777.
ghemawat added a commit to ghemawat/pprof that referenced this issue May 9, 2023
@ghemawat
Made non-D3 flamegraph view the default.
5ab5628 
In preparation for removing the dependency on D3 make the
new flamegraph view the default. The old view is still available
under /flamegraphold for now.

See issue google#777.
ghemawat added a commit to ghemawat/pprof that referenced this issue May 9, 2023
@ghemawat
Made non-D3 flamegraph view the default. (google#777)
fe73b34 
In preparation for removing the dependency on D3 make the
new flamegraph view the default. The old view is still available
under /flamegraphold for now.

See issue google#777.
aalexand added a commit that referenced this issue May 10, 2023
@ghemawat @aalexand
Made non-D3 flamegraph view the default. (#777) (#781)
05f3f57 
In preparation for removing the dependency on D3 make the
new flamegraph view the default. The old view is still available
under /flamegraphold for now.

See issue #777.

Co-authored-by: Alexey Alexandrov <aalexand@users.noreply.github.com>
@aalexand aalexand mentioned this issue May 10, 2023
Merged
@Louis-Ye Louis-Ye added type: cleanup Buganizer type - Internal Cleanup Priority: p2 Buganizer priority - P2 labels May 12, 2023
@aalexand aalexand mentioned this issue Sep 1, 2023
Merged
@dhavaln-able
Copy link

dhavaln-able commented Oct 18, 2023 •
edited
Loading

Just checking, when the d3-dependency supposed to be cleaned up?

@aalexand
Copy link
Collaborator Author

It's probably about the time to do it. The plan was to wait a bit to make sure we hear any potential bug reports about the new default.

aalexand added a commit to aalexand/pprof that referenced this issue Dec 17, 2023
@aalexand
Remove old d3 flamegraph code and d3 dependency.
f69f379 
Fixes google#777.
@aalexand aalexand mentioned this issue Dec 17, 2023
Merged
@aalexand
Copy link
Collaborator Author

@ghemawat We can probably finish this cleanup now - PTAL #825.

aalexand added a commit to aalexand/pprof that referenced this issue Dec 24, 2023
@aalexand
Remove old d3 flamegraph code and d3 dependency.
4d87e8c 
Fixes google#777.
aalexand added a commit that referenced this issue Dec 29, 2023
@aalexand
Remove old d3 flamegraph code and d3 dependency. (#825)
5aaadb5 
Fixes #777.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: p2 Buganizer priority - P2 type: cleanup Buganizer type - Internal Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove old d3 flamegraph code and d3 dependency. aalexand/pprof
3 participants
@aalexand @Louis-Ye @dhavaln-able