From a4bf327b5398e79bb675809346892c1c9dce1370 Mon Sep 17 00:00:00 2001
From: Marcin Kowalczyk <qrczak@google.com>
Date: Thu, 24 Oct 2024 15:11:39 +0200
Subject: [PATCH] Make `InvokerType::Result` present conditionally instead of
 malformed depending on whether the function is callable with the given
 arguments, so that the presence of `Result` and `ConstResult` can be used to
 detect usability of the given instantiation.

Implement conditional functionality by class template specializations instead of
by taking a `bool is_const_callable` template parameter and supplying its value
in the usage later. This feels cleaner.

Add SFINAE constraints to `{,Owning}Invoker()`.

PiperOrigin-RevId: 689352893
---
 riegeli/base/invoker.h | 76 +++++++++++++++++++++++-------------------
 1 file changed, 42 insertions(+), 34 deletions(-)

diff --git a/riegeli/base/invoker.h b/riegeli/base/invoker.h
index 66c1cfa4..b5922765 100644
--- a/riegeli/base/invoker.h
+++ b/riegeli/base/invoker.h
@@ -56,7 +56,18 @@ decltype(std::declval<Function&&>()()) Invoke(Function&& function) {
   return std::forward<Function>(function)();
 }
 
+template <typename Enable, typename Function, typename... Args>
+struct IsCallableImpl : std::false_type {};
+
 template <typename Function, typename... Args>
+struct IsCallableImpl<absl::void_t<decltype(invoker_internal::Invoke(
+                          std::declval<Function>(), std::declval<Args>()...))>,
+                      Function, Args...> : std::true_type {};
+
+template <typename Function, typename... Args>
+struct IsCallable : IsCallableImpl<void, Function, Args...> {};
+
+template <typename Enable, typename Function, typename... Args>
 class InvokerBase : public ConditionallyAssignable<absl::conjunction<
                         absl::negation<std::is_reference<Args>>...>::value> {
  public:
@@ -123,25 +134,18 @@ class InvokerBase : public ConditionallyAssignable<absl::conjunction<
   ABSL_ATTRIBUTE_NO_UNIQUE_ADDRESS std::tuple<Args...> args_;
 };
 
-template <typename Enable, typename Function, typename... Args>
-struct IsConstCallableImpl : std::false_type {};
-
-template <typename Function, typename... Args>
-struct IsConstCallableImpl<
-    absl::void_t<decltype(invoker_internal::Invoke(
-        std::declval<const Function&>(), std::declval<const Args&>()...))>,
-    Function, Args...> : std::true_type {};
-
+// Disable functionality when the function is not callable with the arguments.
 template <typename Function, typename... Args>
-struct IsConstCallable : IsConstCallableImpl<void, Function, Args...> {};
+class InvokerBase<std::enable_if_t<!IsCallable<Function&&, Args&&...>::value>,
+                  Function, Args...> {};
 
-template <bool is_const_callable, typename Function, typename... Args>
-class InvokerConstBase;
-
-template <typename Function, typename... Args>
-class InvokerConstBase</*is_const_callable=*/false, Function, Args...>
-    : public InvokerBase<Function, Args...> {
+template <typename Enable, typename Function, typename... Args>
+class InvokerConstBase : public InvokerBase<void, Function, Args...> {
  public:
+  // The result of calling `const InvokerType&` with no arguments.
+  using ConstResult = decltype(invoker_internal::Invoke(
+      std::declval<const Function&>(), std::declval<const Args&>()...));
+
   using InvokerConstBase::InvokerBase::InvokerBase;
 
   InvokerConstBase(InvokerConstBase&& that) = default;
@@ -149,11 +153,21 @@ class InvokerConstBase</*is_const_callable=*/false, Function, Args...>
 
   InvokerConstBase(const InvokerConstBase& that) = default;
   InvokerConstBase& operator=(const InvokerConstBase& that) = default;
+
+  // Calls the function.
+  using InvokerConstBase::InvokerBase::operator typename InvokerConstBase::
+      Result;
+  /*implicit*/ operator ConstResult() const& {
+    return absl::apply(this->function(), this->args());
+  }
 };
 
+// Disable const functionality when the const function is not callable with the
+// const arguments.
 template <typename Function, typename... Args>
-class InvokerConstBase</*is_const_callable=*/true, Function, Args...>
-    : public InvokerBase<Function, Args...> {
+class InvokerConstBase<
+    std::enable_if_t<!IsCallable<const Function&, const Args&...>::value>,
+    Function, Args...> : public InvokerBase<void, Function, Args...> {
  public:
   using InvokerConstBase::InvokerBase::InvokerBase;
 
@@ -162,17 +176,6 @@ class InvokerConstBase</*is_const_callable=*/true, Function, Args...>
 
   InvokerConstBase(const InvokerConstBase& that) = default;
   InvokerConstBase& operator=(const InvokerConstBase& that) = default;
-
-  // The result of calling `const InvokerType&` with no arguments.
-  using ConstResult = decltype(invoker_internal::Invoke(
-      std::declval<const Function&>(), std::declval<const Args&>()...));
-
-  // Calls the function.
-  using InvokerConstBase::InvokerBase::operator typename InvokerConstBase::
-      Result;
-  /*implicit*/ operator ConstResult() const& {
-    return absl::apply(this->function(), this->args());
-  }
 };
 
 }  // namespace invoker_internal
@@ -193,9 +196,7 @@ class InvokerConstBase</*is_const_callable=*/true, Function, Args...>
 // the target reference, reference wrapper, or pointer.
 template <typename Function, typename... Args>
 class InvokerType
-    : public invoker_internal::InvokerConstBase<
-          invoker_internal::IsConstCallable<Function, Args...>::value, Function,
-          Args...> {
+    : public invoker_internal::InvokerConstBase<void, Function, Args...> {
  public:
   using InvokerType::InvokerConstBase::InvokerConstBase;
 
@@ -277,7 +278,10 @@ using InvokerResultT = typename InvokerResult<T>::type;
 // storing a `InvokerType` in a variable or returning it from a function, use
 // `riegeli::OwningInvoker(function, args...)` or construct `InvokerType`
 // directly.
-template <typename Function, typename... Args>
+template <
+    typename Function, typename... Args,
+    std::enable_if_t<invoker_internal::IsCallable<Function&&, Args&&...>::value,
+                     int> = 0>
 inline InvokerType<Function&&, Args&&...> Invoker(
     Function&& function ABSL_ATTRIBUTE_LIFETIME_BOUND,
     Args&&... args ABSL_ATTRIBUTE_LIFETIME_BOUND) {
@@ -287,7 +291,11 @@ inline InvokerType<Function&&, Args&&...> Invoker(
 // `riegeli::OwningInvoker()` is like `riegeli::Invoker()`, but the arguments
 // are stored by value instead of by reference. This is useful for storing the
 // `InvokerType` in a variable or returning it from a function.
-template <typename Function, typename... Args>
+template <
+    typename Function, typename... Args,
+    std::enable_if_t<invoker_internal::IsCallable<std::decay_t<Function>,
+                                                  std::decay_t<Args>...>::value,
+                     int> = 0>
 inline InvokerType<std::decay_t<Function>, std::decay_t<Args>...> OwningInvoker(
     Function&& function, Args&&... args) {
   return {std::forward<Function>(function), std::forward<Args>(args)...};