Moved pylint to stand-alone CI test target (#831)

Author: joachimmetz

.travis.yml

@@ -1,16 +1,37 @@
-language: python
-python:
-  - '2.7'
-  - '3.6'
-node_js: '8'
+matrix:
+  include:
+  - name: "Pylint on Ubuntu Xenial (16.04) with Python 3.5"
+    env: TARGET="pylint"
+    os: linux
+    dist: xenial
+    group: edge
+    language: python
+    python: 3.5
+    node_js: '8'
+    virtualenv:
+      system_site_packages: true
+  - name: "Ubuntu Xenial (16.04) with Python 2.7"
+    env: TARGET="linux-python27"
+    os: linux
+    dist: xenial
+    group: edge
+    language: python
+    python: 2.7
+    node_js: '8'
+  - name: "Ubuntu Xenial (16.04) with Python 3.6"
+    env: TARGET="linux-python36"
+    os: linux
+    dist: xenial
+    group: edge
+    language: python
+    python: 3.6
+    node_js: '8'
 cache:
-  - yarn
-  - pip
-
+- yarn
+- pip
 install:
-  - pip install .
-  - yarn install
-
+- pip install -r requirements.txt
+- if test ${TARGET} = "pylint"; then pip install astroid==1.5.3 pylint==1.7.2; fi
+- yarn install
 script:
-  - ./run_tests.py --full
-  - yarn run build
+- ./config/travis/run_with_timeout.sh 30 ./config/travis/runtests.sh

config/travis/run_with_timeout.sh

@@ -0,0 +1,47 @@
+#!/bin/bash
+#
+# Script to run commands on a Travis-CI test VM that otherwise would time out
+# after 10 minutes. This replaces travis_wait and outputs stdout of the command
+# running.
+#
+# This file is generated by l2tdevtools update-dependencies.py, any dependency
+# related changes should be made in dependencies.ini.
+
+# Exit on error.
+set -e
+
+# Usage: ./run_with_timeout.sh [TIMEOUT] [COMMAND] [OPTION] [...]
+
+TIMEOUT=$1;
+shift
+
+# Launch a command in the background.
+$* &
+
+PID_COMMAND=$!;
+
+# Probe the command every minute.
+MINUTES=0;
+
+while kill -0 ${PID_COMMAND} >/dev/null 2>&1;
+do
+	# Print to stdout, seeing this prints a space and a backspace
+	# there is no visible trace.
+	echo -n -e " \b";
+
+	if test ${MINUTES} -ge ${TIMEOUT};
+	then
+		kill -9 ${PID_COMMAND} >/dev/null 2>&1;
+
+		echo -e "\033[0;31m[ERROR] command: $* timed out after: ${MINUTES} minute(s).\033[0m";
+
+		exit 1;
+	fi
+	MINUTES=$(( ${MINUTES} + 1 ));
+
+	sleep 60;
+done
+
+wait ${PID_COMMAND};
+
+exit $?;

config/travis/runtests.sh

@@ -0,0 +1,34 @@
+#!/bin/bash
+#
+# Script to run tests on Travis-CI.
+#
+# This file is generated by l2tdevtools update-dependencies.py, any dependency
+# related changes should be made in dependencies.ini.
+
+# Exit on error.
+set -e;
+
+if test "${TARGET}" = "pylint";
+then
+	pylint --version
+
+	for FILE in `find run_tests.py setup.py config timesketch tests -name \*.py`;
+	do
+		echo "Checking: ${FILE}";
+
+		pylint --rcfile=.pylintrc ${FILE};
+	done
+
+	for FILE in `find api_client -name \*.py`;
+	do
+		echo "Checking: ${FILE}";
+
+		PYTHONPATH=api_client/python pylint --rcfile=.pylintrc ${FILE};
+	done
+
+elif test "${TRAVIS_OS_NAME}" = "linux";
+then
+	python ./run_tests.py --full
+
+	yarn run build
+fi

requirements.in

@@ -32,7 +32,6 @@ altair>=2.4.1
 Flask-Testing
 nose
 mock
-pylint
 coverage
 
 # Remove the following when pip-sync finally stops deleting pkg_resources.

requirements.txt

@@ -3,9 +3,7 @@ altair==2.4.1
 amqp==2.2.1               # via kombu
 aniso8601==1.2.1          # via flask-restful
 asn1crypto==0.24.0        # via cryptography
-astroid==1.5.3            # via pylint
 attrs==18.2.0             # via jsonschema
-backports.functools-lru-cache==1.4  # via astroid, pylint
 bcrypt==3.1.3             # via flask-bcrypt
 billiard==3.5.0.3         # via celery
 blinker==1.4
@@ -14,7 +12,7 @@ certifi==2017.7.27.1      # via requests
 cffi==1.10.0              # via bcrypt, cryptography
 chardet==3.0.4            # via requests
 click==6.7                # via flask
-configparser==3.5.0       # via entrypoints, pylint
+configparser==3.5.0       # via entrypoints
 coverage==4.4.1
 cryptography==2.4.1
 datasketch==1.2.5
@@ -34,15 +32,13 @@ funcsigs==1.0.2           # via mock
 gunicorn==19.7.1
 idna==2.6                 # via cryptography, requests
 ipaddress==1.0.22         # via cryptography
-isort==4.2.15             # via pylint
 itsdangerous==0.24        # via flask
 jinja2==2.10              # via altair, flask
 jsonschema==3.0.0         # via altair
 kombu==4.1.0              # via celery
 lazy-object-proxy==1.3.1  # via astroid
 mako==1.0.7               # via alembic
 markupsafe==1.0           # via jinja2, mako
-mccabe==0.6.1             # via pylint
 mock==2.0.0
 neo4jrestclient==2.1.1
 nose==1.3.7
@@ -52,16 +48,14 @@ parameterized==0.6.1
 pbr==3.1.1                # via mock
 pycparser==2.18           # via cffi
 pyjwt==1.6.4
-pylint==1.7.2
 pyrsistent==0.14.11       # via jsonschema
 python-dateutil==2.6.1
 python-editor==1.0.3      # via alembic
 pytz==2017.2              # via celery, flask-restful, pandas
 pyyaml==4.2b4
 redis==2.10.6
 requests==2.20.1
-singledispatch==3.4.0.3   # via astroid, pylint
-six==1.12.0               # via altair, astroid, bcrypt, cryptography, flask-restful, jsonschema, mock, pylint, pyrsistent, python-dateutil, singledispatch
+six==1.12.0               # via altair, bcrypt, cryptography, flask-restful, jsonschema, mock, pyrsistent, python-dateutil
 sqlalchemy==1.1.13
 toolz==0.9.0              # via altair
 typing==3.6.6             # via altair

run_tests.py

@@ -21,21 +21,9 @@ def run_python_tests(coverage=False):
     finally:
         subprocess.check_call(['rm', '-f', '.coverage'])
 
-def run_python_linter():
-    subprocess.check_call(['pylint', 'timesketch'])
-    subprocess.check_call(
-        'PYTHONPATH=api_client/python/:$PYTHONPATH'
-        + ' pylint timesketch_api_client',
-        shell=True,
-    )
-    subprocess.check_call(['pylint', 'run_tests'])
-    subprocess.check_call(['pylint', 'setup'])
-
 def run_python(args):
     if not args.no_tests:
         run_python_tests(coverage=args.coverage)
-    if not args.no_lint:
-        run_python_linter()
 
 def run_javascript_tests(coverage=False):
     if coverage: