Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: create internal request type identifier for ComputeEngineCredentials getMetadataResponse() #1680

Open
zhumin8 opened this issue Feb 21, 2025 · 0 comments
Open

cleanup: create internal request type identifier for ComputeEngineCredentials getMetadataResponse() #1680

zhumin8 opened this issue Feb 21, 2025 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@zhumin8
Copy link
Contributor

zhumin8 commented Feb 21, 2025

context: #1586 (comment)

both metric and logging can benefit from this piece of information passing down. A minor refactor should achieve this.
@zhumin8 zhumin8 added priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern. labels Feb 21, 2025
@zhumin8 zhumin8 mentioned this issue Feb 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhumin8