Skip to content

cleanup(storage)!: trim methods and messages #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

coryan
Copy link
Collaborator

@coryan coryan commented Apr 25, 2025

We only want the admin RPCs and their messages in this client.

Part of the work for #1813

We only want the admin RPCs and their messages in this client.
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (952a2e6) to head (7af2403).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1925   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          56       56           
  Lines        2042     2042           
=======================================
  Hits         1967     1967           
  Misses         75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review April 25, 2025 18:59
@coryan coryan requested a review from a team as a code owner April 25, 2025 18:59
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: names for the admin vs. data plane crates?

I assumed google-cloud-storage would be the data plane.

Should we rename this one to google-cloud-storage-admin (or storage-control or something)?

@coryan
Copy link
Collaborator Author

coryan commented Apr 25, 2025

Just curious: names for the admin vs. data plane crates?

I assumed google-cloud-storage would be the data plane.

Should we rename this one to google-cloud-storage-admin (or storage-control or something)?

Yup. This crate should be renamed. I updated the tracking bug.

@coryan coryan merged commit d8d1a9a into googleapis:main Apr 25, 2025
21 checks passed
@coryan coryan deleted the cleanup-storage-remove-data-plane-methods branch April 25, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants