impl(wkt): helper type for i32 deserialization
#2334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProtoJSON requires accepting both strings and integers for integers. This PR only adds support for signed 32-bit integers. Future PRs will deal with unsigned integers and with 64-bit integers. The changes to the generator and the generated code will also happen in separate PRs.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2334 +/- ##
==========================================
- Coverage 93.92% 93.79% -0.13%
==========================================
Files 64 66 +2
Lines 2781 2838 +57
==========================================
+ Hits 2612 2662 +50
- Misses 169 176 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amanda-tarafa
previously approved these changes
May 30, 2025
dbolduc
previously approved these changes
May 30, 2025
dbolduc
approved these changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProtoJSON requires accepting both strings and integers for integers. This PR
only adds support for signed 32-bit integers. Future PRs will deal with
unsigned integers and with 64-bit integers.
The changes to the generator and the generated code will also happen in
separate PRs.
Fixes #2323