Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpResponseException is platform dependent #1419

Open
elharo opened this issue Aug 2, 2021 · 2 comments
Open

HttpResponseException is platform dependent #1419

elharo opened this issue Aug 2, 2021 · 2 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. semver: patch A minor bug fix or small change. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@elharo
Copy link
Contributor

elharo commented Aug 2, 2021

The use of StringUtils.LINE_SEPARATOR in HttpResponseException is incorrect. It produces platform dependent output. This is bad practice. It should be the same constant string on all platforms.
@elharo elharo added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. semver: patch A minor bug fix or small change. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Aug 2, 2021
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jan 29, 2022
@suztomo
Copy link
Member

suztomo commented Aug 23, 2022

Memo. This is the code:

google-http-java-client/google-http-client/src/main/java/com/google/api/client/http/HttpResponseException.java

Line 193 in ea0f6c0

builder.append(StringUtils.LINE_SEPARATOR).append(content);

@daniel-odrinski
Copy link

Hi, I would like to pick this issue up if that's ok?

I intend to go with Linux's \n instead of StringUtils.LINE_SEPARATOR.
Is there a class in which constants are declared? I am asking so that I can avoid adding the string inline.

Thanks.

@ldetmer ldetmer added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. semver: patch A minor bug fix or small change. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@suztomo @elharo @ldetmer @daniel-odrinski @yoshi-automation