Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample: update quickstart snippet #354

Open
4 tasks
freelerobot opened this issue Dec 9, 2020 · 1 comment
Open
4 tasks

Sample: update quickstart snippet #354

freelerobot opened this issue Dec 9, 2020 · 1 comment
Assignees
Labels
api: logging Issues related to the googleapis/java-logging API. good first issue This issue is a good place to started contributing to this repository. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@freelerobot
Copy link
Contributor

freelerobot commented Dec 9, 2020

Improve the Logging quickstart in Java. Quickstart should work out of the box and contain all the instructions (in comments) so users can immediately see their logs.

Additional criteria:

  • include comments on various ways to authenticate
  • encourage users to log with standard log wrapper Logback rather than directly writing LogEntries. Context: In an ideal world, customers should be able to use existing logging frameworks native to their language. With some simple appender/handler to also ship logs to Cloud Logging. Customers aren't locked into logging library syntax, thus it's easier to both onboarding and offboard off of these client libraries.
  • comment that if users need more customizable logs, redirect to writing log entries
  • if applicable, a test for this sample
@freelerobot freelerobot added the good first issue This issue is a good place to started contributing to this repository. label Dec 9, 2020
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Dec 9, 2020
@freelerobot freelerobot added samples Issues that are directly related to samples. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Dec 9, 2020
@suraj-qlogic suraj-qlogic self-assigned this Dec 10, 2020
@suraj-qlogic suraj-qlogic removed their assignment Jan 20, 2021
@simonz130 simonz130 self-assigned this May 20, 2021
@simonz130 simonz130 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label May 20, 2021
@simonz130 simonz130 assigned minherz and unassigned simonz130 Jan 26, 2022
@simonz130
Copy link

@minherz this bug covers remainder samples work in the repo for structured logging in java.

@minherz minherz assigned arbrown and unassigned minherz Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. good first issue This issue is a good place to started contributing to this repository. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

5 participants