-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update default Python version to 3.12 for tests and formatting #93
base: main
Are you sure you want to change the base?
Conversation
Owlbot is failing at the final step:
I suspect this is because the |
@@ -41,6 +41,7 @@ | |||
"3.13": extras_bf, | |||
} | |||
templated_files = common.py_library( | |||
default_python_version="3.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default_python_version="3.9", | |
default_python_version="3.12", |
Correct, only 3.8 and 3.10 are available in owlbot-python. We could update 3.8 to a newer runtime given that it's almost EOL https://github.com/googleapis/synthtool/blob/master/docker/owlbot/python/Dockerfile |
We could consider removing the automatic code formatting and add a presubmit to fail if the code is does not meet formatting requirements. Alternatively, code formatting could be outside of WDYT about removing the lines below? python-bigquery-magics/owlbot.py Lines 101 to 103 in 6c2ac31
|
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕