CLN: remove workaround for streaming delays. #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that load jobs are used, no sleep is required when replacing a table.
|
Nice. Slight tangent, but we could think about only doing one chunk, which would mean we could fall back to the replace / amend / overwrite native implementations rather than writing our own |
|
Yeah, someone reported that at #107 I agree we should do it. We could even do it if we keep chunking by having subsequent load jobs be "append" mode, but it could also be a good opportunity to deprecate chunks since it's actually not all that helpful when using load jobs (which are a limited resource of 1,000 / day). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that load jobs are used, no sleep is required when replacing a table.
Tests with credentials running at https://travis-ci.org/tswast/pandas-gbq/builds/375003060