fix: updated dependencies to solve compilation issue #1557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhawk
approved these changes
May 2, 2024
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| #Wed May 01 14:29:09 CEST 2024 | ||
| distributionBase=GRADLE_USER_HOME |
There was a problem hiding this comment.
Extra carriage returns here?
There was a problem hiding this comment.
This is automatically added when using ./gradlew wrapper to update the Gradle version. We can probably leave it as it is.
|
🎉 This PR is included in version 1.10.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
kikoso
added a commit
that referenced
this pull request
Aug 14, 2024
* fix: versions and dependencies updated to allow compilation * fix: duplicated libraries * fix: updated Gradle * fix: updated Manifest * fix: updated Gradle * fix: fixed header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #1554 and enables again the compilation of all samples.
Like it often happens, the initial idea was to simply upgrade the
compileSdkversion to make it work again.(narrator voice: it wasn't that simple)
This required:
This update should give some peace of mind to the
android-samplesproject.Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1554 🦕