-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent migration attempt #256
base: master
Are you sure you want to change the base?
Conversation
> convert to direct unity call to java add signin in editor and desktop support
Fix signOut and disconnect
seems it was needed...
Fixes & Improvements
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@calumma-robert Do you interest in signing google CLA agreement? |
@Thaina done! |
Thank you very much |
Migrate ios to 7.1.0
update readme
3da1816
to
6c3c741
Compare
GoogleSignIn.Configuration ??= new GoogleSignInConfiguration()
{
WebClientId = Env.GoogleWebClientId,
RequestIdToken = true,
UseGameSignIn = false,
RequestEmail = true,
HidePopups = true
};
var user = await DefaultInstance.SignInSilentlyAsync(); |
@nixonjoshua98 I have push the new fix to allow auto signin for device with multiple account. But I just have found some detailed concern about this case https://developer.android.com/identity/sign-in/credential-manager-siwg#enable-sign-in As there is mention about criteria to auto signin. Even we have auto signin for the device with multiple account, if there is also more than one account had ever signin to your app, the account selector will still be launched anyway in the same manner you have experienced The stackoverflow answer above have mention that you might need to revoke access to the app from the account too, and have only one account connect to the app I have just create google issue for request a feature to specified email hint (as the new identity signin system was not contain API to set a hint anymore). Would you pleased to upvote this issue too? |
Much love, I've upvoted it. Thanks for the quick responses |
Is there any update on 'silently' sign in ? @Thaina @nixonjoshua98 |
I went with the approach of storing an encrypted token after signing in, which stores your login preference. Let's me skip the Google login popup, and I just send that token to my backend. |
It should be silent if you have only one account signing in into your app in your device, isn't it? |
Yes, it's working and doesn't open dialog ui of account selecting but still encounter the following error in the logs during a slientlysignin : NoCredentialException: During begin sign-in, failure response from one tap: 16: User disabled the feature Upon researching this error, I discovered that it occurs when the Google account's sign-in prompt is disabled. Specifically, if a user has only one account signed in and has disabled the one-tap sign-in feature in their Google account settings, this error is generated. When I enabled the one-tap sign-in for the affected Google account, the error disappeared. However, the account selection dialog appears again. Steps to Reproduce
|
Based on your step, isn't those expected behaviour? Or are there other behaviour we should have? |
@nivedhKA Where is that setting, i can't seem to find it? I have this exception for a couple of users as well. |
In Android Device -> Open Settings -> Find Google Account -> Select Google Account And Select -> Open Manage Account And Search Sign In prompts. |
@nivedhKA I think I just understand your issue I think what you trying to do, which is disabling signinprompt, are not given what you expected What I think it would is revoking the signin of the app from all of your accounts except one, which is difference thing from just disabling signin prompt I am not testing it yet but maybe this might work |
@Thaina Is there a unity package? Or how to build it. to google |
I don't know, I don't use unitypackage to the point I already forgot how to made it properly for package I would like to also dissuade on using unitypackage. Are there any reason you cannot move on to use upm instead? |
Thank you. |
Log more exception fill logic with condition
Is there any update on 'silently' sign in ? @Thaina @nixonjoshua98 even with one account also same popup !!! each time it asking to select account to login !!! |
@shiva30122 We need more log to investigate |
Doubts ?........ Android Works is IOS will be Easy ?? to make Sign ??? 100% iam needed WebClint ID on IOS to get AuthCode is it Possible ? And I also need to create separate IOS Clint ID whare 2 ClientID -> IOS ClientID and IOS ClientID Revers ??..... And how to Use ??? ANY TIPS ?...... Edited : New to GitHub !... |
@shiva30122 We need more log to investigate and it surely will be some log around the silentsignin especially before popup occur You need to understand the engineering process about how to debug your system on device. Or else no one can help you. Don't just throw random message around chaotically About 2 clientID. You can write |
and i tried using only one google account on my mobile then also popup thins select account for silent login() !. Debugging is not showing any error and it simply login me both normal Sign() or Silently-Login() . my problem is Silent Login() Issue when user already Login !..... and i tried with code also for making silent login on Star() method not working !. any solution !??? or Still Development ?... or i need to implement anything manually ??... now my problem is clear !?.. Unity.package --> Silently-Login_Notworking.zip iam using Unity 6 . but in last iam getting Debug.Log("ServerAuthCode : " + authCode) ; !.. Working bit only silent login() issue !. Refer My Video --> https://youtu.be/6DQGnQv-GL0 |
@shiva30122 There are 3 things I can think of |
@shiva30122 Please investigate the https://developer.android.com/identity/sign-in/credential-manager-siwg#enable-sign-in |
Since there is deprecation and migration recommendation from signin system
: copied from readme >
https://developer.android.com/identity/sign-in/legacy-gsi-migration
https://developers.google.com/identity/sign-in/ios/quick-migration-guide
Thank for ios fix which was cherrypicked from this fork : https://github.com/pillsgood/google-signin-unity
Android was migrated to use
CredentialManager
andAuthorizationClient
since GoogleSignInAccount was deprecatedHowever,
GoogleIdTokenCredential
actually not provide numeric unique ID anymore and set email as userId instead, so I have to extract jwtsub
value from idToken (which seem like the same id as userId from GoogleSignIn of other platform)Tested in unity 2021.3.21 and unity 6000.0.4
Add UPM dependency with branch tag
https://github.com/Thaina/google-signin-unity.git#newmigration