Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Feature] Auth supports session driver #547

Open
1 task done
hwbrzzl opened this issue Dec 29, 2024 · 5 comments · May be fixed by goravel/framework#820
Open
1 task done

✨ [Feature] Auth supports session driver #547

hwbrzzl opened this issue Dec 29, 2024 · 5 comments · May be fixed by goravel/framework#820
Assignees
@KlassnayaAfrodita
Labels
✏️ Feature

Comments

@hwbrzzl
Copy link
Contributor

hwbrzzl commented Dec 29, 2024

Before feedback (在反馈之前)

  • There are no features that I want to submit in Issues (当前 Issues 中没有我将要提交的新功能)

Describe Feature (描述功能)

Currently, Auth only supports JWT driver, we want to add the session driver since framework supports the session feature.
@github-actions GitHub Actions
Copy link

Hi @hwbrzzl 👋

We think your feedback is very valuable! If you are interested, please submit a PR, please include test cases, documentation, etc., and ensure that the CI is passed, thank you and look forward to your contribution!
我们认为您的反馈非常有价值！如果有兴趣欢迎提交 PR，请包含相应的测试用例、文档等，并确保 CI 通过，感谢和期待您的贡献！

@KlassnayaAfrodita
Copy link

hey, I can try to take care of this issue

@hwbrzzl
Copy link
Contributor Author

hwbrzzl commented Dec 30, 2024

Sure, thanks!

@devhaozi devhaozi moved this to 📋 To do in Goravel Development Dashboard Jan 2, 2025
@KlassnayaAfrodita
Copy link

hey, I added a file with the implementation of auth using sessions. Please check KlassnayaAfrodita/framework#2

@hwbrzzl
Copy link
Contributor Author

hwbrzzl commented Jan 16, 2025

Thanks! why not create a PR for goravel/framework?

@KlassnayaAfrodita KlassnayaAfrodita mentioned this issue Jan 16, 2025
Closed
1 task
@hwbrzzl hwbrzzl linked a pull request Feb 7, 2025 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KlassnayaAfrodita KlassnayaAfrodita

Labels
✏️ Feature
Projects
Goravel Development Dashboard
Status: 📋 To do
Milestone
No milestone
2 participants
@hwbrzzl @KlassnayaAfrodita