Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Improve single place result handling and job completion #98

Closed
wants to merge 2 commits into from

Conversation

bugkerb
Copy link
Contributor

@bugkerb bugkerb commented Nov 26, 2024

  • Add delay when waiting for redirect URL to handle single place results
  • Fix scrollbar detection for single result cases
  • Add proper job completion handling with exit monitor

Jiratthapol Aroyvithee and others added 2 commits November 20, 2024 14:57
- Add delay when waiting for redirect URL to handle single place results
- Fix scrollbar detection for single result cases
- Add proper job completion handling with exit monitor
@gosom
Copy link
Owner

gosom commented Dec 8, 2024

@bugkerb thanks for the PR.

I haven't found the time to check yet. Will do the next days

apologies for the delay

@gosom
Copy link
Owner

gosom commented Dec 15, 2024

@bugkerb

do you mind fixing the linter error?

https://github.com/gosom/google-maps-scraper/actions/runs/12029219575/job/34432880229#step:5:201

run locally with make lint to see the error in your computer.

thank you very much for the PR

@buaatian
Copy link

I met this problem, and this commit works so well! Hope to be merged asap!

@adelindanaila
Copy link

It will be great to merge this

@gosom
Copy link
Owner

gosom commented Jan 19, 2025

I messed up git a bit and created a new PR. Your commits are still there.
apologies for that

#115

@bugkerb @adelindanaila @buaatian it will be merged in a few mins

@gosom gosom closed this Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants