Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update CSS to use CSS variables for colors #490

Merged

Conversation

Bridgetamana
Copy link
Contributor

Description

Add CSS variables for the colors used in main.css

Issue Reference

Fixes #480

Checklist

Please ensure the following before submitting the PR:

  • I have tested the changes locally, and they work as expected.
  • The code follows the project's coding standards and conventions.
  • I have updated relevant documentation (if needed).
  • I have added unit tests or performed manual testing where necessary.

Screenshots (applicable to user interface changes)

Copy link
Member

@Ainali Ainali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have tested it, and it looks just as expected.
The only thing I am not sure of, but this may not be a blocker, is if it would be useful to put the root definitions at the top? This is what I have encountered before, but it may not matter much. What do you think @Abbe98 ?

@Ainali Ainali requested a review from Abbe98 January 13, 2025 10:31
Copy link
Member

@Abbe98 Abbe98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, only left to move the declarations to the top as suggested by @Ainali!

@Bridgetamana
Copy link
Contributor Author

I have done that

@RVA2869 RVA2869 requested a review from Abbe98 January 13, 2025 11:42
@Ainali Ainali merged commit 430cb77 into govdirectory:main Jan 13, 2025
1 check passed
@Bridgetamana Bridgetamana deleted the feature/add-css-color-variables branch January 13, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CSS variables for the colors used in main.css
3 participants