Skip to content
This repository has been archived by the owner on Dec 21, 2020. It is now read-only.

Add the optimize parameter to the route api client #47

Open
cvhue opened this issue May 2, 2017 · 2 comments
Open

Add the optimize parameter to the route api client #47

cvhue opened this issue May 2, 2017 · 2 comments

Comments

@cvhue
Copy link

cvhue commented May 2, 2017

GraphHopper routing API has a property optimize. However, the java client does not make use of it. In the response creation, it is not checked whether points_order is present.
Also, the PathWrapper of the general api does not have the property of the sequence of points.

@karussell
Copy link
Member

Indeed we should have a look into this. For the mean time you could have a look into the auto-created java client: https://github.com/boldtrn/graphhopper-routing-api-swagger/tree/master/java

In the response creation, it is not checked whether points_order is present.

What do you mean here?

Also, the PathWrapper of the general api does not have the property of the sequence of points.

Hmmh, this is a bit ugly as we use the Java object of the core here and sequence of points is always the same and would make no sense there.

@karussell
Copy link
Member

Maybe you add this to our swagger config as a pull request? Then I can update the client. See the examples https://github.com/graphhopper/directions-api-java-client/blob/master/client-examples/src/main/java/com/graphhopper/directions/api/examples/RoutingExample.java

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants