Skip to content
This repository has been archived by the owner on Dec 16, 2020. It is now read-only.

Add documentation about ShortFastestWeighting #70

Open
boldtrn opened this issue Feb 26, 2018 · 5 comments
Open

Add documentation about ShortFastestWeighting #70

boldtrn opened this issue Feb 26, 2018 · 5 comments
Labels

Comments

@boldtrn
Copy link
Member

boldtrn commented Feb 26, 2018

Currently the API docs miss information about the short_fastest.time_factor and the short_fastest.distance_factor and how to use it.

@karussell
Copy link
Member

I'm not sure if we should document them as these parameters are really low level and for LM we should not allow a decrease.

@boldtrn
Copy link
Member Author

boldtrn commented Mar 8, 2018

Yes, but how would anyone be able to use the ShortFastestWeighting if we don't document it properly? Not everyone can/wants to look into the code. I think it's a nice feature and maybe some more people would like to use it, but don't understand it?

@karussell
Copy link
Member

Yes, but how would anyone be able to use the ShortFastestWeighting if we don't document it properly?

you can switch from fastest to short_fastest and trust us that we defined proper defaults :)

@boldtrn
Copy link
Member Author

boldtrn commented Mar 16, 2018

you can switch from fastest to short_fastest and trust us that we defined proper defaults :)

But isn't the big "feature" of the ShortFastestWeighting that a user can provide their own values?

@karussell
Copy link
Member

karussell commented Mar 16, 2018

I think the users usually want either "fastest" or "shortest" but with "shortest" they don't mean actual the "shortest" route, but a fast route that further considers distance. At this time I would not want to offer these additional parameters to the public. We should really consider investing into issue 1112 of GH core to use a much more powerful JSON request where tuning things like this will feel natural and logic.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants