Skip to content

Dev container fixes and updates #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 29, 2025
Merged

Dev container fixes and updates #1173

merged 15 commits into from
May 29, 2025

Conversation

RembrandtK
Copy link
Contributor

@RembrandtK RembrandtK commented May 15, 2025

Fixes and updates:

  • removing unneeded shared network dependency
  • documentation updates
  • remove duplicated git signing message
  • do not install hardhat (global install not a good idea)
  • install cloc and a script to use it to count Solidity code changes relative to main
  • ignore forge-artifacts

scripts/count-changes not about dev container but useful script.

Everything else relates just to dev container configuration.

@RembrandtK RembrandtK requested a review from Copilot May 15, 2025 11:27
@RembrandtK RembrandtK self-assigned this May 15, 2025
Copilot

This comment was marked as outdated.

@RembrandtK RembrandtK requested a review from Copilot May 15, 2025 11:38
Copilot

This comment was marked as outdated.

More robust handling of unusual filenames.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@RembrandtK RembrandtK requested a review from Copilot May 15, 2025 11:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the dev container configuration and supporting scripts, removing unused dependencies and enhancing documentation. Key changes include:

  • A new script (scripts/count-changes) to count Solidity code changes using cloc.
  • Removal of the shared network dependency and duplicate Git SSH signing message in the dev container settings.
  • Updates to the Dockerfile to remove global Hardhat installation and install only the necessary packages.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
scripts/count-changes Adds a script for counting Solidity code changes using cloc.
packages/issuance/lib/forge-std Adds a submodule commit reference for the forge-std library.
.devcontainer/project-setup.sh Removes a duplicate Git SSH signing message to avoid redundancy.
.devcontainer/docker-compose.yml Removes the unneeded shared network configuration.
.devcontainer/README.md Updates documentation for clarity regarding container usage.
.devcontainer/Dockerfile Eliminates global Hardhat installation; now installs ethers and cloc.

@RembrandtK RembrandtK requested a review from tmigone May 15, 2025 11:52
tmigone
tmigone previously approved these changes May 23, 2025
@RembrandtK RembrandtK merged commit 03ffaa9 into main May 29, 2025
4 checks passed
@RembrandtK RembrandtK deleted the dev-container branch May 29, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants