Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read config without metadata on verifyAll #912

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

pcarranzav
Copy link
Member

Fixes #871

@pcarranzav pcarranzav requested review from tmigone and Maikol January 11, 2024 20:31
tmigone
tmigone previously approved these changes Jan 12, 2024
Maikol
Maikol previously approved these changes Jan 12, 2024
@pcarranzav pcarranzav force-pushed the pcv/fix-cli-wrapcalls branch from bb98512 to 78bb79f Compare January 12, 2024 13:28
Base automatically changed from pcv/fix-cli-wrapcalls to main January 12, 2024 14:32
@pcarranzav pcarranzav dismissed stale reviews from Maikol and tmigone January 12, 2024 14:32

The base branch was changed.

@pcarranzav pcarranzav closed this Jan 12, 2024
@pcarranzav pcarranzav reopened this Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (78bb79f) 92.69% compared to head (2b7ee89) 92.69%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #912   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files          46       46           
  Lines        2369     2369           
  Branches      426      426           
=======================================
  Hits         2196     2196           
  Misses        173      173           
Flag Coverage Δ
unittests 92.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmigone tmigone merged commit 8210a6f into main Jan 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: verifyAll task failing when reading from config
3 participants