graph: Prevent duplicate source subgraphs in manifest validation

graphprotocol · Feb 11, 2025 · b6b97d7 · b6b97d7
1 parent 0260db4
commit b6b97d7
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/graph/src/data/subgraph/mod.rs b/graph/src/data/subgraph/mod.rs
@@ -719,6 +719,23 @@ impl<C: Blockchain> UnvalidatedSubgraphManifest<C> {
             ));
         }
 
+        // Check for duplicate source subgraphs
+        let mut seen_sources = std::collections::HashSet::new();
+        for ds in data_sources.iter() {
+            if let DataSource::Subgraph(ds) = ds {
+                let source_id = ds.source.address();
+                if !seen_sources.insert(source_id.clone()) {
+                    errors.push(SubgraphManifestValidationError::DataSourceValidation(
+                        "subgraph".to_string(),
+                        anyhow!(
+                            "Multiple subgraph datasources cannot use the same source subgraph {}",
+                            source_id
+                        ),
+                    ));
+                }
+            }
+        }
+
         errors
     }
 

diff --git a/graph/src/data_source/subgraph.rs b/graph/src/data_source/subgraph.rs
@@ -292,9 +292,7 @@ impl UnresolvedDataSource {
             .iter()
             .any(|ds| matches!(ds, crate::data_source::DataSource::Subgraph(_)))
         {
-            return Err(anyhow!(
-                "Nested subgraph data sources are not supported."
-            ));
+            return Err(anyhow!("Nested subgraph data sources are not supported."));
         }
 
         if source_spec_version < &SPEC_VERSION_1_3_0 {