Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix adapter startup #5503

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix adapter startup #5503

merged 1 commit into from
Jun 21, 2024

Conversation

mangas
Copy link
Contributor

@mangas mangas commented Jun 21, 2024

No description provided.

@mangas mangas marked this pull request as ready for review June 21, 2024 11:21
@mangas mangas force-pushed the filipe/fix-adapters branch from 29f0159 to a55174a Compare June 21, 2024 11:29
Comment on lines 400 to 401
/// - Substreams chain are created as a "secondary" chain for deep integrations but in that case the block ingestor
/// should be run by the main/deep integration chain.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify this comment a bit more, i don't really understand what it means by that the ingestor is to by run by the deep integration chain?

So for a substreams based chain integration the block ingestor needs to be a normal one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just a bit weird, since substreams is defined as both a substreams chain and an adapter type, if you have protocol = Ethereum on the toml then you need an rpc or firehose. If you have 'protocol = substreams' then you just need a substreams endpoint and cannot use any other kind.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried to improve the comment a bit, since this is somewhat urgent I will merge once it's green but if this is still unclear we can discuss how to better expose this information

@mangas mangas force-pushed the filipe/fix-adapters branch from 2c6f925 to 8361154 Compare June 21, 2024 19:05
@mangas mangas merged commit 7b4fff2 into master Jun 21, 2024
7 checks passed
@mangas mangas deleted the filipe/fix-adapters branch June 21, 2024 19:23
codebuster22 pushed a commit to chain-labs/ag-graph-node that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants