changed test to cover full response control

Author: jmccaull

src/test/groovy/graphql/servlet/AbstractGraphQLHttpServletSpec.groovy

@@ -285,7 +285,7 @@ class AbstractGraphQLHttpServletSpec extends Specification {
         getBatchedResponseContent()[1].data.echo == "test"
     }
 
-    def "Execution Result Handler allows limiting number of queries"() {
+    def "Batch Execution Handler allows limiting batches and sending error messages."() {
         setup:
         servlet = TestUtils.createBatchCustomizedServlet({ env -> env.arguments.arg }, { env -> env.arguments.arg }, { env ->
             AtomicReference<SingleSubscriberPublisher<String>> publisherRef = new AtomicReference<>()
@@ -304,9 +304,8 @@ class AbstractGraphQLHttpServletSpec extends Specification {
         servlet.doGet(request, response)
 
         then:
-        response.getStatus() == STATUS_OK
-        response.getContentType() == CONTENT_TYPE_JSON_UTF8
-        getBatchedResponseContent().size() == 2
+        response.getStatus() == STATUS_BAD_REQUEST
+        response.getErrorMessage() == TestBatchExecutionHandler.BATCH_ERROR_MESSAGE
     }
 
     def "Default Execution Result Handler does not limit number of queries"() {

src/test/groovy/graphql/servlet/TestBatchExecutionHandler.java

@@ -13,16 +13,29 @@
 
 public class TestBatchExecutionHandler implements BatchExecutionHandler {
 
+    public static String BATCH_ERROR_MESSAGE = "Batch limit exceeded";
+
     @Override
     public void handleBatch(GraphQLBatchedInvocationInput batchedInvocationInput, HttpServletResponse response, GraphQLObjectMapper graphQLObjectMapper,
                             BiFunction<GraphQLInvocationInput, ExecutionInput, ExecutionResult> queryFunction) {
-        List<ExecutionResult> results = batchedInvocationInput.getExecutionInputs().parallelStream()
-            .limit(2)
+        List<ExecutionInput> inputs = batchedInvocationInput.getExecutionInputs();
+        if (inputs.size() > 2) {
+            handleBadInput(response);
+        }
+        List<ExecutionResult> results = inputs.parallelStream()
             .map(input -> queryFunction.apply(batchedInvocationInput, input))
             .collect(Collectors.toList());
         writeResults(results, response, graphQLObjectMapper);
     }
 
+    private void handleBadInput(HttpServletResponse response) {
+        try {
+            response.sendError(HttpServletResponse.SC_BAD_REQUEST, BATCH_ERROR_MESSAGE);
+        } catch (IOException e) {
+            throw new RuntimeException(e);
+        }
+    }
+
     private void writeResults(List<ExecutionResult> results, HttpServletResponse response, GraphQLObjectMapper mapper) {
         response.setContentType(AbstractGraphQLHttpServlet.APPLICATION_JSON_UTF8);
         response.setStatus(AbstractGraphQLHttpServlet.STATUS_OK);