-
Notifications
You must be signed in to change notification settings - Fork 4
Upgrade Docusaurus to v3.7 #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently the build is failing with:
|
Amplify deployment status
|
Building with |
@taraspos answering your comment here: facebook/docusaurus#10556 (comment) If it works with cc @hardfist It can be reproduced using latest Docusaurus canary using When disabling Docusaurus Faster options related to SWC, it still reproduces: const config: Config = {
future: {
v4: true,
experimental_faster: {
swcJsLoader: false,
swcJsMinimizer: false,
swcHtmlMinimizer: false,
lightningCssMinimizer: true,
rspackBundler: true,
mdxCrossCompilerCache: true,
ssgWorkerThreads: true,
},
},
} However, when disabling Rspack (using Webpack), it doesn't crash anymore. const config: Config = {
future: {
v4: true,
experimental_faster: {
swcJsLoader: true,
swcJsMinimizer: true,
swcHtmlMinimizer: true,
lightningCssMinimizer: true,
rspackBundler: false,
mdxCrossCompilerCache: true,
ssgWorkerThreads: true,
},
},
} However, we still get various errors:
Your repro is not really usable as is since the However, fixing the errors above does not fix the Rspack/SWC crash. Reverting to Rspack 1.1 fixes the bundling crash: "resolutions": {
"@rspack/core": "1.1.8"
}, |
@slorber, thanks for such a detailed response! |
The bug has been fixed in our deps, I guess it should work soon on our next release |
Thanks @slorber ! |
np 👍 Try Rspack 1.2.3, this might fix the problem (not sure): |
4763ce1
to
a07ebde
Compare
The Rust panic error should be fixed in https://github.com/web-infra-dev/rspack/releases/tag/v1.2.5 (included in SWC 14 upgrade) |
bd93a84
to
385412a
Compare
After upgrading to Docusaurus 3.7 we were experiencing some build issues with SVGs: It turns out that in Docusaurus 3.7 SVG support was extracted so we needed to add the package to our dependencies and add it to the plugins section of |
b74492b
to
20beb99
Compare
20beb99
to
698eddc
Compare
f86cc5d
to
9411551
Compare
Summary
Upgrade Docusaurus to 3.7:
@rspack/core
tov1.2.5
to fix build issues (Thanks @slorber):width 3 given for non-narrow character
error when building certain libraries web-infra-dev/rspack#9075Testing
Preview looks good: