Add links to top-level sidebar categories #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amplify deployment status
|
|
Reviewer note: eventually we can convert |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
avatus
approved these changes
Mar 14, 2025
server/config-docs.ts
Outdated
Comment on lines
386
to
398
| if (category.entries.some((e) => e.slug.match(categoryDirPattern)[2] == "")) { | ||
| return "index"; | ||
| } |
There was a problem hiding this comment.
this this index [2] guaranteed to exist?
There was a problem hiding this comment.
My impression was that the caller would always supply a valid slug, but I should prevent bad inputs anyway—I've added better exception handling and some tests in 2ad40d7
Contributes to #87 Top-level sidebar categories do not have links, meaning that when a user clicks a sidebar category, it expands, but does not take the user to a category index page as they might expect. Category index pages are listed as regular pages among other regular pages (another change will handle the redundant menu page sidebar listings). This change edits the code that converts the `config.json` configuration file into a Docusaurus navigation config. It adds a Docusaurus `link` to each top-level navigation category based on the root path segment shared by all slugs within the category.
- Remove unnecessary double negation. - Add an escape character to `categoryDirPattern` - Handle invalid entry slugs and add tests for invalid `getIndexPageID` cases
ptgott
force-pushed
the
paul.gottschling/287-config-fix
branch
from
d1fd7e8 to
2ad40d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #87
Top-level sidebar categories do not have links, meaning that when a user clicks a sidebar category, it expands, but does not take the user to a category index page as they might expect. Category index pages are listed as regular pages among other regular pages (another change will handle the redundant menu page sidebar listings).
This change edits the code that converts the
config.jsonconfiguration file into a Docusaurus navigation config. It adds a Docusauruslinkto each top-level navigation category based on the root path segment shared by all slugs within the category.