Configure required GHA jobs for merge_group #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amplify deployment status
|
taraspos
reviewed
Apr 24, 2025
|
|
||
| jobs: | ||
| run-tests: | ||
| name: Run tests | ||
| if: ${{ github.event_name != 'merge_group' }} |
There was a problem hiding this comment.
We could probably run this on merge queue as well, it won't hurt I guess.
taraspos
approved these changes
Apr 24, 2025
|
I just tried to add it to the merge queue and seems like it didn't work for CodeQL and Dependency Check workflows. 
|
ptgott
force-pushed
the
paul.gottschling/2025-04-23-merge-group
branch
from
3bdbd0e to
729030f
Compare
We recently configured docs-website to use merge queues, and have one job with a `merge_group` trigger. Since the required checks do not have a `merge_group` trigger, though, merge queues time out waiting for checks to be reported. - Move the docs build check into Amplify Preview. A job called "Amplify Preview" is required to run. Move the "Check the docs build" step into the docs preview workflow. Run one of two "Amplify Preview" jobs depending on the event type. - Trigger all expected workflows on the `merge_group` event, but add an `if` condition so they pass if the event is merge_group. Do not add an `if` condition to the `Dependency Review` job, since it seems to conflict with the `uses` field. The job takes < 30s, so there is not much harm in running it on `merge_group`.
ptgott
force-pushed
the
paul.gottschling/2025-04-23-merge-group
branch
from
729030f to
b3f907f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently configured docs-website to use merge queues, and have one job with a
merge_grouptrigger. Since the required checks do not have amerge_grouptrigger, though, merge queues time out waiting for checks to be reported.Move the docs build check into Amplify Preview. A job called "Amplify Preview" is required to run. Move the "Check the docs build" step into the docs preview workflow. Run one of two "Amplify Preview" jobs depending on the event type.
Trigger all expected workflows on the
merge_groupevent, but add anifcondition so they pass if the event is merge_group