Skip to content

only make NewDefaultServer once when neccessary #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/conn.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,15 @@ func NewConn(conn net.Conn, user string, password string, h Handler) (*Conn, err
p.AddUser(user, password)

var packetConn *packet.Conn
if defaultServer.tlsConfig != nil {
if defaultServer().tlsConfig != nil {
packetConn = packet.NewTLSConn(conn)
} else {
packetConn = packet.NewConn(conn)
}

c := &Conn{
Conn: packetConn,
serverConf: defaultServer,
serverConf: defaultServer(),
credentialProvider: p,
h: h,
connectionID: atomic.AddUint32(&baseConnID, 1),
Expand Down
2 changes: 1 addition & 1 deletion server/server_conf.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
. "github.com/go-mysql-org/go-mysql/mysql"
)

var defaultServer = NewDefaultServer()
var defaultServer = sync.OnceValue(NewDefaultServer)

// Defines a basic MySQL server with configs.
//
Expand Down
Loading