Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pydantic version range to support higher version #48

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

honeytung
Copy link
Member

Small PR change to support higher pydantic version for other projects that requires a higher version.

Copy link
Collaborator

@brandon-groundlight brandon-groundlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing in this PR makes me think we need to go to 0.6.0. If we had a breaking change in the previous PR, we should update the releases

@@ -1,6 +1,6 @@
[tool.poetry]
name = "framegrab"
version = "0.5.5"
version = "0.6.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure updating pydantic here is a breaking change, 2.5.3 is still valid under ^2.5.3

Copy link
Collaborator

@brandon-groundlight brandon-groundlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current release is 5.4, and there is a breaking change on main. Updating to 0.6.0 recognizes that the current tip of main has a breaking change.

@honeytung honeytung merged commit 89a00b0 into main Jul 23, 2024
3 checks passed
@honeytung honeytung deleted the pydantic-version-fix branch July 23, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants