Fix bug in wait_for_confident_result #317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
confidence_threshold
parameter defaults toNone
, and the docstring states that if it isNone
then the detector's confidence threshold will be used. However, it currently only fetches the detector's confidence threshold if the value forimage_query
is a string - if you pass it anImageQuery
object,confidence_threshold
will still beNone
when passed toiq_is_confident
, which will then error when trying to doiq.result.confidence >= confidence_threshold
.This fixes it so it will always fetch the detector's confidence threshold if the inputted
confidence_threshold
is None.