Moved react-is to peer dependency
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjordanxd
commented
Jan 30, 2025
Comment on lines
+54
to
+55
| "react": "^18.0.0 || ^19.0.0", | ||
| "react-is": "^18.0.0 || ^19.0.0" |
There was a problem hiding this comment.
support both v18 and v19
|
Good solution. In the old world where Noticed recently that the popular library recharts addresses this another way by requiring the consuming app use LGTM, will update README and ship a v5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Moving
react-istopeerDependenciesgives this packages better support for a wider range of React versions. Consumers should ensure the version ofreact-isinstall is the same as their version ofreact. I'm not sure if we can enforce this somehow? This PR is a breaking change but it will resolve the following warning on the repo:I'm not entirely sure if we need to update any logic traversing the tree. I believe the tree structure is consistent between different versions of React.