Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/multiple equivalent images SBOM poc #2467

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robert-cronin
Copy link
Collaborator

@robert-cronin robert-cronin commented Jan 28, 2025

Description of the PR

Partial fix for #2387

The main idea in this PR is to detect if an image being ingested has a SBOM that describes the same digest but has a different image uri and then create an IsOccurrence edge between them in a hub and spoke pattern (hub being the Artifact node and spokes being the Package nodes).

Note: this is just a POC, presumably we would want the reference attestations to be pre-created and therefore simply ingested instead of being created in a certifier-like way. That is my current best thinking, but I am open to alternate ways to achieve this.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@robert-cronin robert-cronin self-assigned this Jan 28, 2025
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
@robert-cronin robert-cronin force-pushed the feat/multiple-equivalent-images-sbom-poc branch from 9e2bd89 to 007bc05 Compare January 29, 2025 22:51
@robert-cronin
Copy link
Collaborator Author

Here is a rough diagram showing the logic I am trying to model with this approach:
Untitled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant