refactor: Improve error handling and type usage in pipeline traits

- Update NEON files to reflect additional errors and type coverage
- Add 'typePerfect.narrowPublicClassMethodParamType' NEON file for error tracking
- Modify pipeline traits to use 'get' method for better encapsulation
- Enhance PHPStan configuration for stricter type checking

Author: guanguans

baselines/loader.neon

@@ -1,8 +1,9 @@
-# total 10 errors
+# total 11 errors
 includes:
     - disallowed.function.neon
     - function.alreadyNarrowedType.neon
     - method.notFound.neon
     - nullCoalesce.variable.neon
     - trait.unused.neon
     - typeCoverage.paramTypeCoverage.neon
+    - typePerfect.narrowPublicClassMethodParamType.neon

baselines/typePerfect.narrowPublicClassMethodParamType.neon

@@ -0,0 +1,8 @@
+# total 1 error
+
+parameters:
+    ignoreErrors:
+        -
+            message: '#^Parameters should have "Guanguans\\LaravelApiResponse\\Pipes\\CastDataPipe" types as the only types passed to this method$#'
+            count: 1
+            path: ../src/ApiResponse.php

composer.json

@@ -64,6 +64,7 @@
         "phpstan/phpstan-webmozart-assert": "^2.0",
         "povils/phpmnd": "^3.6",
         "rector/rector": "^2.0",
+        "rector/type-perfect": "^2.0",
         "shipmonk/composer-dependency-analyser": "^1.8",
         "shipmonk/phpstan-baseline-per-identifier": "^2.1",
         "spatie/pest-plugin-snapshots": "^1.1 || ^2.0",

phpstan.neon

@@ -46,6 +46,13 @@ parameters:
         param_type: 100
         property_type: 100
         constant_type: 100
+    type_perfect:
+        narrow_param: true
+        narrow_return: true
+        null_over_false: true
+        no_mixed: true
+        no_mixed_property: true
+        no_mixed_caller: true
     disallowedFunctionCalls:
         -
             function: 'env()'
@@ -70,4 +77,5 @@ parameters:
         - identifier: missingType.iterableValue
         - identifier: new.static
         - identifier: offsetAccess.nonArray
-        - identifier: return.type
+        - identifier: return.type
+        - identifier: typePerfect.noMixedMethodCaller

src/Concerns/HasExceptionPipes.php

@@ -91,12 +91,12 @@ private function spliceExceptionPipes(string $findExceptionPipe, array $exceptio
             if (0 === $idx) {
                 $this->exceptionPipes->unshift(...$exceptionPipes);
             } else {
-                $this->exceptionPipes->splice($idx, 1, [...$exceptionPipes, $this->exceptionPipes[$idx]]);
+                $this->exceptionPipes->splice($idx, 1, [...$exceptionPipes, $this->exceptionPipes->get($idx)]);
             }
         } elseif ($this->exceptionPipes->count() - 1 === $idx) {
             $this->exceptionPipes->push(...$exceptionPipes);
         } else {
-            $this->exceptionPipes->splice($idx, 1, [$this->exceptionPipes[$idx], ...$exceptionPipes]);
+            $this->exceptionPipes->splice($idx, 1, [$this->exceptionPipes->get($idx), ...$exceptionPipes]);
         }
 
         return $this;

src/Concerns/HasPipes.php

@@ -96,12 +96,12 @@ private function splicePipes(string $findPipe, array $pipes, bool $before): self
             if (0 === $idx) {
                 $this->pipes->unshift(...$pipes);
             } else {
-                $this->pipes->splice($idx, 1, [...$pipes, $this->pipes[$idx]]);
+                $this->pipes->splice($idx, 1, [...$pipes, $this->pipes->get($idx)]);
             }
         } elseif ($this->pipes->count() - 1 === $idx) {
             $this->pipes->push(...$pipes);
         } else {
-            $this->pipes->splice($idx, 1, [$this->pipes[$idx], ...$pipes]);
+            $this->pipes->splice($idx, 1, [$this->pipes->get($idx), ...$pipes]);
         }
 
         return $this;

src/Pipes/IterableDataPipe.php

@@ -41,7 +41,6 @@ public function handle(array $structure, \Closure $next): JsonResponse
 
     private function dataFor(mixed $data): mixed
     {
-        // return is_iterable($data) && !\is_array($data) ? iterator_to_array($data) : $data;
         return $data instanceof \Traversable ? iterator_to_array($data) : $data;
     }
 }

src/Support/Traits/WithPipeArgs.php

@@ -17,10 +17,6 @@ trait WithPipeArgs
 {
     public static function with(mixed ...$args): string
     {
-        if ([] === $args) {
-            return static::class;
-        }
-
-        return static::class.':'.implode(',', $args);
+        return [] === $args ? static::class : static::class.':'.implode(',', $args);
     }
 }