Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Higher density widget #1127

Merged
merged 13 commits into from
Feb 13, 2025
Merged

UI - Higher density widget #1127

merged 13 commits into from
Feb 13, 2025

Conversation

nopdive
Copy link
Collaborator

@nopdive nopdive commented Feb 13, 2025

image

We're wasting too many pixels on having a separate metrics bar. Controls and metrics (which are horizontal scrollable) are now in the same bar.

Additional changes:

  • Metrics are contextual. I.e. GPU / CPU usage is reported only while the cell is running, while token reduction and related are shown at completion.
  • Fix for memory metrics (was percentage, now in GB).
  • Metrics provide more description on hover. We have very short one word metrics, which has plenty of ambiguity as a sacrifice to reduce horizontal space.

Shout-outs to Jingya & Nick (high-density sketches, frontend discussion)!

@nopdive nopdive changed the title UI - Controls and metrics are now on the same bar. UI - Higher density widget Feb 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.14%. Comparing base (788b468) to head (321423b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
guidance/models/_model.py 44.44% 5 Missing ⚠️
guidance/visual/_renderer.py 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1127       +/-   ##
===========================================
+ Coverage   43.18%   54.14%   +10.95%     
===========================================
  Files          70       70               
  Lines        5777     5777               
===========================================
+ Hits         2495     3128      +633     
+ Misses       3282     2649      -633     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Every metric zero'd out before metrics are sent to frontend.
@nking-1
Copy link
Collaborator

nking-1 commented Feb 13, 2025

Looks great. I like the compressed bar. Very nice!

Code looks good too.

MetricCard fully renamed to MetricRecord.
@nopdive nopdive merged commit f9926a3 into guidance-ai:main Feb 13, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants