Skip to content

Commit 28fbaca

Browse files
pdehaanphated
authored andcommitted
Build: Add eslint and jscs (closes #1, closes #2, closes #3)
1 parent e099ae9 commit 28fbaca

File tree

7 files changed

+19
-21
lines changed

7 files changed

+19
-21
lines changed

.eslintrc

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,3 @@
11
{
2-
"ecmaFeatures": {
3-
"jsx": true
4-
},
5-
"rules": {
6-
"semi": [2, "always"],
7-
"quotes": [2, "single"],
8-
"strict": [2, "global"],
9-
"no-underscore-dangle": 0
10-
},
11-
"env": {
12-
"es6": true,
13-
"browser": true,
14-
"node": true
15-
}
2+
"extends": "gulp"
163
}

.jscsrc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"preset": "gulp"
3+
}

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# default-resolution
22

3-
[![Travis Build Status](https://img.shields.io/travis/phated/default-resolution/master.svg?label=travis&style=flat-square)](https://travis-ci.org/phated/default-resolution)
3+
[![Travis Build Status](https://img.shields.io/travis/gulpjs/default-resolution/master.svg?label=travis&style=flat-square)](https://travis-ci.org/gulpjs/default-resolution)
44

55
Get the default resolution time based on the current node version, optionally overridable
66

7-
Originally implemented by @dinoboff in https://github.com/phated/undertaker/pull/17
7+
Originally implemented by @dinoboff in https://github.com/gulpjs/undertaker/pull/17
88

99
Split out for standalone use.
1010

@@ -29,7 +29,7 @@ defaultResolution(12);
2929
| 0.10 | 1s |
3030
| 0.11+ | 1ms |
3131

32-
More information at https://github.com/phated/undertaker/pull/17#issuecomment-82374512
32+
More information at https://github.com/gulpjs/undertaker/pull/17#issuecomment-82374512
3333

3434
# License
3535

node-version.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ var match = process.version.match(/v(\d+)\.(\d+)\.(\d+)/);
44
var nodeVersion = {
55
major: match[1],
66
minor: match[2],
7-
patch: match[3]
7+
patch: match[3],
88
};
99

1010
module.exports = nodeVersion;

package.json

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"contributors": [
77
"Damien Lebrun <dinoboff@hotmail.com>"
88
],
9-
"repository": "phated/default-resolution",
9+
"repository": "gulpjs/default-resolution",
1010
"license": "MIT",
1111
"engines": {
1212
"node": ">= 0.10"
@@ -18,11 +18,16 @@
1818
"node-version.js"
1919
],
2020
"scripts": {
21-
"test": "lab -cvL"
21+
"lint": "eslint . && jscs *.js test/",
22+
"test": "lab -cv"
2223
},
2324
"dependencies": {},
2425
"devDependencies": {
2526
"code": "^1.4.0",
27+
"eslint": "^1.7.3",
28+
"eslint-config-gulp": "^2.0.0",
29+
"jscs": "^2.4.0",
30+
"jscs-preset-gulp": "^1.0.0",
2631
"lab": "^5.5.1"
2732
},
2833
"keywords": [

test/.eslintrc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"extends": "gulp/test"
3+
}

test/default-resolution.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ var defaultResolution = require('../');
77
var nodeVersion = require('../node-version');
88

99
lab.describe('defaultResolution', function() {
10-
// typically I don't unit test helpers, but this reduces the last run tests
10+
// Typically I don't unit test helpers, but this reduces the last run tests
1111
var major = nodeVersion.major;
1212
var minor = nodeVersion.minor;
1313

0 commit comments

Comments
 (0)