Skip to content

Commit 7427e0b

Browse files
committed
Fix: Ensure node version was integer
1 parent 28fbaca commit 7427e0b

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

node-version.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
var match = process.version.match(/v(\d+)\.(\d+)\.(\d+)/);
44
var nodeVersion = {
5-
major: match[1],
6-
minor: match[2],
7-
patch: match[3],
5+
major: parseInt(match[1], 10),
6+
minor: parseInt(match[2], 10),
7+
patch: parseInt(match[3], 10),
88
};
99

1010
module.exports = nodeVersion;

test/default-resolution.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,16 @@ var code = require('code');
66
var defaultResolution = require('../');
77
var nodeVersion = require('../node-version');
88

9+
lab.describe('nodeVersion', function() {
10+
11+
lab.it('has all integers and not strings', function(done) {
12+
code.expect(nodeVersion.major).to.be.a.number();
13+
code.expect(nodeVersion.minor).to.be.a.number();
14+
code.expect(nodeVersion.patch).to.be.a.number();
15+
done();
16+
});
17+
});
18+
919
lab.describe('defaultResolution', function() {
1020
// Typically I don't unit test helpers, but this reduces the last run tests
1121
var major = nodeVersion.major;

0 commit comments

Comments
 (0)