Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compound references to rivers #13

Open
lintool opened this issue Feb 29, 2020 · 4 comments
Open

Compound references to rivers #13

lintool opened this issue Feb 29, 2020 · 4 comments

Comments

@lintool
Copy link
Member

lintool commented Feb 29, 2020

This might be a weird corner case, but we have:
Nelson-Churchill river basin: https://www.wikidata.org/wiki/Q64767961

But, there's no Nelson-Churchill Rivers, because Nelson River and Churchill River each have their own entities.

It might be not uncommon to have such compound references? E.g., Mississippi/Missouri Rivers?

@lintool
Copy link
Member Author

lintool commented Feb 29, 2020

Here's the specific instance: https://www.frdr-dfdr.ca/repo/handle/doi:10.20383/101.0154

@Govind9
Copy link
Collaborator

Govind9 commented Mar 6, 2020

These cases are also handled:
image

But there's a catch. Some rivers appear in wikidata in two (or more) forms like: "Mississippi" and "Mississippi river". For such rivers, this case is being handled. But some rivers appear only like this: "Nelson river". So these won't be picked up. I can force the phrases to have both forms for every river/lake and that will cover this.

@lintool
Copy link
Member Author

lintool commented Mar 7, 2020

hi @Govind9 I'd like to play the system myself once you have it properly refactored. I also want to consider these cases in the context of unit cases.

@Govind9
Copy link
Collaborator

Govind9 commented Mar 7, 2020

I noticed there are lakes and rivers of the same name. For example:

Nelson river: https://www.wikidata.org/wiki/Q3292
Nelson lake: https://www.wikidata.org/wiki/Q20707922

It is easy to differentiate if the sentence itself has "Nelson river" or "Nelson lake" but what if just the word "Nelson" is there or "Nelson-Churchill" is there alone in the text without any qualifier like river or lake. What should take precedence in these cases, River or Lake?
Btw, Churchill too is a river and a lake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants