Skip to content

Commit 147e79f

Browse files
committed
[Bugfix] Incorrectly passing a pointer to a funtion taking const reference
Passing a pointer to to NimBLEUtils::taskWait and NimBLEUtils::taskRelease would compile due to the first argument in the constructor being a pointer to void, a surprisingly not a compiler error in this instance. Also does not cause a crash but instead a hung task when called.
1 parent cdd313f commit 147e79f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/NimBLERemoteCharacteristic.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ bool NimBLERemoteCharacteristic::retrieveDescriptors(NimBLEDescriptorFilter* pFi
118118
}
119119

120120
auto prevDscCount = m_vDescriptors.size();
121-
NimBLEUtils::taskWait(pFilter->taskData, BLE_NPL_TIME_FOREVER);
121+
NimBLEUtils::taskWait(taskData, BLE_NPL_TIME_FOREVER);
122122
rc = ((NimBLETaskData*)pFilter->taskData)->m_flags;
123123
if (rc != BLE_HS_EDONE) {
124124
NIMBLE_LOGE(LOG_TAG, "<< retrieveDescriptors(): failed: rc=%d %s", rc, NimBLEUtils::returnCodeToString(rc));

0 commit comments

Comments
 (0)