Skip to content

Commit 2f3dc3a

Browse files
committed
Bugfix: add missing taskData when retrieving all descriptors
1 parent 5179398 commit 2f3dc3a

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/NimBLERemoteCharacteristic.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,10 @@ NimBLERemoteDescriptor* NimBLERemoteCharacteristic::getDescriptor(const NimBLEUU
176176
*/
177177
const std::vector<NimBLERemoteDescriptor*>& NimBLERemoteCharacteristic::getDescriptors(bool refresh) const {
178178
if (refresh) {
179+
NimBLETaskData taskData(const_cast<NimBLERemoteCharacteristic*>(this));
180+
NimBLEDescriptorFilter filter = {nullptr, nullptr, &taskData};
179181
deleteDescriptors();
180-
retrieveDescriptors();
182+
retrieveDescriptors(&filter);
181183
}
182184

183185
return m_vDescriptors;

src/NimBLERemoteCharacteristic.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ class NimBLERemoteCharacteristic : public NimBLERemoteValueAttribute {
6767
~NimBLERemoteCharacteristic();
6868

6969
bool setNotify(uint16_t val, notify_callback notifyCallback = nullptr, bool response = true) const;
70-
bool retrieveDescriptors(NimBLEDescriptorFilter* filter = nullptr) const;
70+
bool retrieveDescriptors(NimBLEDescriptorFilter* filter) const;
7171

7272
static int descriptorDiscCB(
7373
uint16_t connHandle, const ble_gatt_error* error, uint16_t chrHandle, const ble_gatt_dsc* dsc, void* arg);

0 commit comments

Comments
 (0)