configMAX_PRIORITIES seems to be incorrect value for freeRTOS task priority

[pwilkowski]

According to freertos docs , task should have maximum priority of configMAX_PRIORITIES - 1
https://www.freertos.org/Documentation/02-Kernel/02-Kernel-features/01-Tasks-and-co-routines/03-Task-priorities

Which seems to be bigger here

ll_task_h = xTaskCreateStatic(nimble_port_ll_task_func, "ll", NIMBLE_LL_STACK_SIZE,
                                  NULL, configMAX_PRIORITIES, ll_xStack, &ll_xTaskBuffer);

NimBLE-Arduino/src/nimble/porting/npl/freertos/src/nimble_port_freertos.c

Line 114 in 62180ab

ll_task_h = xTaskCreateStatic(nimble_port_ll_task_func, "ll", NIMBLE_LL_STACK_SIZE,

This issue may be related: #584

[h2zero]

Thanks! not sure how it was missed and also apparently working for so long...

[pwilkowski]

after enabling debugging for tasks in free rots i see this:

i came to conclusions

1. let Ble tasks to have configurable priorities
2. by default imo it should be configMAX_PRIORITIES -1 and configMAX_PRIORITIES - 2 so they dont collide with built in Tmr task

I made a pull request #934

after changes:

[h2zero]

Closing this as fixed in #891